Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: renamewhaction andaction toresource_action in CLI#2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intomainfromjlvillal/resource
Jun 5, 2022

Conversation

JohnVillalovos
Copy link
Member

Rename the variableswhaction andaction toresource_action to
improve code-readability.

@codecov-commenter
Copy link

codecov-commenter commentedJun 4, 2022•
edited
Loading

Codecov Report

Merging#2054 (fb3f28a) intomain (6cdccd9) willnot change coverage.
The diff coverage is100.00%.

@@           Coverage Diff           @@##             main    #2054   +/-   ##=======================================  Coverage   94.52%   94.52%           =======================================  Files          78       78             Lines        4972     4972           =======================================  Hits         4700     4700             Misses        272      272
FlagCoverage Δ
cli_func_v482.54% <100.00%> (ø)
py_func_v480.99% <0.00%> (ø)
unit85.47% <0.00%> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/cli.py100.00% <100.00%> (ø)
gitlab/v4/cli.py90.47% <100.00%> (ø)

Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@JohnVillalovos! looks good just a tiny comment about the help string.

Rename the variables `whaction` and `action` to `resource_action` toimprove code-readability.
@nejchnejch merged commit61b8beb intomainJun 5, 2022
@nejchnejch deleted the jlvillal/resource branchJune 5, 2022 16:00
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nejchnejchnejch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@JohnVillalovos@codecov-commenter@nejch
[8]ページ先頭
©2009-2025 Movatter.jp