- Notifications
You must be signed in to change notification settings - Fork673
chore: renamewhat togitlab_resource#2053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Less confusing to have it be a normal method.
Naming a variable `what` makes it difficult to understand what it isused for.Rename it to `gitlab_resource` as that is what is being stored.The Gitlab documentation talks about them being resources:https://docs.gitlab.com/ee/api/api_resources.htmlThis will improve code readability.
81664b0 toc86e471Comparecodecov-commenter commentedJun 4, 2022
Codecov Report
@@ Coverage Diff @@## main #2053 +/- ##======================================= Coverage 94.52% 94.52% ======================================= Files 78 78 Lines 4972 4972 ======================================= Hits 4700 4700 Misses 272 272
Flags with carried forward coverage won't be shown.Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I guesswhaction should also be calledresource_action then to match, if it doesn't get too verbose. But we can do that later
Uh oh!
There was an error while loading.Please reload this page.
NOTE: This is based on top of PR:#2052
So can merge this and get both commits or merge#2052 first.
Naming a variable
whatmakes it difficult to understand what it isused for.
Rename it to
gitlab_resourceas that is what is being stored.The Gitlab documentation talks about them being resources:
https://docs.gitlab.com/ee/api/api_resources.html
This will improve code readability.