Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: haveEncodedId creation always returnEncodedId#2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intomainfromjlvillal/type_alias
May 31, 2022

Conversation

JohnVillalovos
Copy link
Member

There is no reason to return anint as we can always return astr
version of theint

ChangeEncodedId to always return anEncodedId. This removes the
need to havemypy ignore the error raised.

@codecov-commenter
Copy link

codecov-commenter commentedMay 31, 2022•
edited
Loading

Codecov Report

Merging#2040 (a1a246f) intomain (3fa330c) willincrease coverage by0.00%.
The diff coverage is100.00%.

@@           Coverage Diff           @@##             main    #2040   +/-   ##=======================================  Coverage   93.68%   93.68%           =======================================  Files          78       78             Lines        4985     4986    +1     =======================================+ Hits         4670     4671    +1  Misses        315      315
FlagCoverage Δ
cli_func_v481.78% <100.00%> (-0.02%)⬇️
py_func_v480.68% <100.00%> (+<0.01%)⬆️
unit85.01% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/utils.py93.24% <100.00%> (+0.09%)⬆️

@JohnVillalovosJohnVillalovos marked this pull request as draftMay 31, 2022 19:17
@JohnVillalovosJohnVillalovos marked this pull request as ready for reviewMay 31, 2022 19:40
@JohnVillalovosJohnVillalovos marked this pull request as draftMay 31, 2022 19:52
Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM just one question :)

There is no reason to return an `int` as we can always return a `str`version of the `int`Change `EncodedId` to always return an `EncodedId`. This removes theneed to have `mypy` ignore the error raised.
@JohnVillalovosJohnVillalovos marked this pull request as ready for reviewMay 31, 2022 23:09
@nejchnejch merged commitdea9435 intomainMay 31, 2022
@nejchnejch deleted the jlvillal/type_alias branchMay 31, 2022 23:19
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nejchnejchnejch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@JohnVillalovos@codecov-commenter@nejch
[8]ページ先頭
©2009-2025 Movatter.jp