NotificationsYou must be signed in to change notification settings
Fork675
Star2.4k

chore: update type-hints return signature for GetWithoutIdMixin methods#2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nejch merged 1 commit intomainfromjlvillal/get_not_none

May 30, 2022

Merged

chore: update type-hints return signature for GetWithoutIdMixin methods#2036

nejch merged 1 commit intomainfromjlvillal/get_not_none

May 30, 2022

Conversation

Copy link

Member

JohnVillalovos commentedMay 30, 2022

Commitf0152dc removed situation
whereget() in aGetWithoutIdMixin based class could returnNone

Update the type-hints to no longer returnOptional AKANone

chore: update type-hints return signature for GetWithoutIdMixin methods

aa972d4

Commitf0152dc removed situationwhere `get()` in a `GetWithoutIdMixin` based class could return `None`Update the type-hints to no longer return `Optional` AKA `None`

JohnVillalovos requested a review fromnejch

May 30, 2022 17:11

Copy link

codecov-commenter commentedMay 30, 2022

Codecov Report

Merging#2036 (aa972d4) intomain (b2e6f3b) willnot change coverage.
The diff coverage is79.31%.

@@           Coverage Diff           @@##             main    #2036   +/-   ##=======================================  Coverage   93.72%   93.72%           =======================================  Files          78       78             Lines        4941     4941           =======================================  Hits         4631     4631             Misses        310      310

Flag	Coverage Δ
cli_func_v4	`81.64% <27.58%> (ø)`
py_func_v4	`80.51% <48.27%> (ø)`
unit	`84.98% <62.06%> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
gitlab/mixins.py	`92.51% <ø> (ø)`
gitlab/v4/objects/push_rules.py	`92.85% <0.00%> (ø)`
gitlab/v4/objects/merge_request_approvals.py	`90.58% <33.33%> (ø)`
gitlab/v4/objects/notification_settings.py	`96.42% <66.66%> (ø)`
gitlab/v4/objects/export_import.py	`94.59% <75.00%> (ø)`
gitlab/v4/objects/appearance.py	`100.00% <100.00%> (ø)`
gitlab/v4/objects/pipelines.py	`94.39% <100.00%> (ø)`
gitlab/v4/objects/projects.py	`89.89% <100.00%> (ø)`
gitlab/v4/objects/settings.py	`95.45% <100.00%> (ø)`
gitlab/v4/objects/statistics.py	`100.00% <100.00%> (ø)`
... and1 more