- Notifications
You must be signed in to change notification settings - Fork675
chore: correct ModuleNotFoundError() arguments#2033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Previously in commit233b79e I hadused the `name` argument for `ModuleNotFoundError()`. This basicallyis the equivalent of not passing any message to`ModuleNotFoundError()`. So when the exception was raised it wasn'tvery helpful.Correct that and add a unit-test that shows we get the message weexpect.
codecov-commenter commentedMay 30, 2022
Codecov Report
@@ Coverage Diff @@## main #2033 +/- ##==========================================+ Coverage 84.98% 93.72% +8.74%========================================== Files 78 78 Lines 4941 4941 ==========================================+ Hits 4199 4631 +432+ Misses 742 310 -432
Flags with carried forward coverage won't be shown.Click here to find out more.
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously in commit233b79e I had
used the
nameargument forModuleNotFoundError(). This basicallyis the equivalent of not passing any message to
ModuleNotFoundError(). So when the exception was raised it wasn'tvery helpful.
Correct that and add a unit-test that shows we get the message we
expect.