Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(ci): replace commitlint with commitizen#1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JohnVillalovos merged 1 commit intomainfromchore/commitizen
May 1, 2022

Conversation

@nejch
Copy link
Member

@nejchnejch commentedApr 30, 2022
edited
Loading

See#1996 (comment)

This also needs a small change in required checks temporarily

@@ -1,5 +1,6 @@
argcomplete==2.0.0
argcomplete<=2.0.0
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'll open a PR in commitizen to bump to v2 so we can pin this again later.

@codecov-commenter
Copy link

codecov-commenter commentedApr 30, 2022
edited
Loading

Codecov Report

Merging#1998 (781be0d) intomain (882fe7a) willincrease coverage by9.11%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #1998      +/-   ##==========================================+ Coverage   83.47%   92.58%   +9.11%==========================================  Files          78       78                Lines        4938     4938              ==========================================+ Hits         4122     4572     +450+ Misses        816      366     -450
FlagCoverage Δ
cli_func_v481.49% <ø> (?)
py_func_v480.49% <ø> (?)
unit83.47% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/base.py92.59% <0.00%> (+0.52%)⬆️
gitlab/exceptions.py100.00% <0.00%> (+0.69%)⬆️
gitlab/config.py94.44% <0.00%> (+1.66%)⬆️
gitlab/v4/objects/members.py94.73% <0.00%> (+1.75%)⬆️
gitlab/v4/objects/export_import.py94.59% <0.00%> (+2.70%)⬆️
gitlab/types.py96.66% <0.00%> (+3.33%)⬆️
gitlab/v4/objects/wikis.py96.42% <0.00%> (+3.57%)⬆️
gitlab/v4/objects/notes.py94.23% <0.00%> (+3.84%)⬆️
gitlab/v4/objects/groups.py88.65% <0.00%> (+4.25%)⬆️
gitlab/v4/objects/jobs.py77.27% <0.00%> (+4.54%)⬆️
... and32 more

@nejchnejch marked this pull request as ready for reviewApril 30, 2022 19:47
Copy link
Member

@JohnVillalovosJohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good. Thanks!

@JohnVillalovosJohnVillalovos merged commitb8d15fe intomainMay 1, 2022
@JohnVillalovosJohnVillalovos deleted the chore/commitizen branchMay 1, 2022 13:51
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JohnVillalovosJohnVillalovosJohnVillalovos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nejch@codecov-commenter@JohnVillalovos

[8]ページ先頭

©2009-2025 Movatter.jp