NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

Add ChunkedEncodingError to list of retryable exceptions#1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nejch merged 1 commit intopython-gitlab:mainfromSineaggi:add-chunked-to-list-of-retryable-exceptions

Apr 14, 2022

Merged

Add ChunkedEncodingError to list of retryable exceptions#1974

nejch merged 1 commit intopython-gitlab:mainfromSineaggi:add-chunked-to-list-of-retryable-exceptions

Apr 14, 2022

Conversation

Copy link

Sineaggi commentedApr 11, 2022

We've been seeing ChunkedEncodingErrors recently as well, I've added them to the list of retryable exceptions.

...  File redacted.py    return typing.cast(GitlabProject, project_manager.get(project_id))  File "/usr/local/lib/python3.10/site-packages/gitlab/v4/objects/projects.py", line 816, in get    return cast(Project, super().get(id=id, lazy=lazy, **kwargs))  File "/usr/local/lib/python3.10/site-packages/gitlab/exceptions.py", line 311, in wrapped_f    return f(*args, **kwargs)  File "/usr/local/lib/python3.10/site-packages/gitlab/mixins.py", line 111, in get    server_data = self.gitlab.http_get(path, **kwargs)  File "/usr/local/lib/python3.10/site-packages/gitlab/client.py", line 761, in http_get    result = self.http_request(  File "/usr/local/lib/python3.10/site-packages/gitlab/client.py", line 680, in http_request    result = self.session.request(  File "/usr/local/lib/python3.10/site-packages/requests/sessions.py", line 529, in request    resp = self.send(prep, **send_kwargs)  File "/usr/local/lib/python3.10/site-packages/requests/sessions.py", line 687, in send    r.content  File "/usr/local/lib/python3.10/site-packages/requests/models.py", line 838, in content    self._content = b''.join(self.iter_content(CONTENT_CHUNK_SIZE)) or b''  File "/usr/local/lib/python3.10/site-packages/requests/models.py", line 763, in generate    raise ChunkedEncodingError(e)requests.exceptions.ChunkedEncodingError: ("Connection broken: InvalidChunkLength(got length b'', 0 bytes read)", InvalidChunkLength(got length b'', 0 bytes read))

Sineaggi force-pushed theadd-chunked-to-list-of-retryable-exceptions branch from8244282 toa746eedCompare

April 11, 2022 18:59

Copy link

codecov-commenter commentedApr 11, 2022•
edited
Loading

Codecov Report

Merging#1974 (8256aff) intomain (5370979) willnot change coverage.
The diff coverage is100.00%.

@@           Coverage Diff           @@##             main    #1974   +/-   ##=======================================  Coverage   92.56%   92.56%           =======================================  Files          78       78             Lines        4910     4910           =======================================  Hits         4545     4545             Misses        365      365

Flag	Coverage Δ
cli_func_v4	`81.58% <0.00%> (ø)`
py_func_v4	`80.12% <0.00%> (ø)`
unit	`83.48% <100.00%> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
gitlab/client.py	`90.56% <100.00%> (ø)`

Sineaggi force-pushed theadd-chunked-to-list-of-retryable-exceptions branch froma746eed to8256affCompare

April 11, 2022 19:37

nejch requested changes

Apr 13, 2022

View reviewed changes

Copy link

Member

nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the addition again@Sineaggi - just a small suggestion.

Let's see if we need to change this in the future, ChunkedEncodingError seems very specific but I see upstream discussions on this inhttps://gitlab.com/gitlab-org/gitlab/-/issues/260310. So it could be the same - did you experience it with job logs?