- Notifications
You must be signed in to change notification settings - Fork674
Fix--job argument interpreted as--job-token#1957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nejch commentedApr 1, 2022
Thanks for the PR@meteozond! could you amend your commit message and force push again? (see CI failure) That is really odd behavior with |
nejch commentedApr 27, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hi@meteozond I'm happy to merge this, just needs a few steps on your end to get green CI: pip install tox# if you don't have toxtox -e blackgit add gitlab/git commit --amend -m"fix(cli): change default`allow_abbrev` value to avoid argument collision"git push -f Let me know if you need any more help. |
nejch commentedMay 9, 2022
Thanks@meteozond for the fix. Your commit will be included in#2013 to get this merged :) |
Description of the problem, including code/CLI snippet
--jobargument interpreted as--job-tokenarugment and conflicts with--private-tokenExecuting:
Expected Behavior
Artifact downloaded
Actual Behavior
gitlab: error: argument --job-token: not allowed with argument --private-tokenSpecifications
PS
Looks like it happens because of default
argparse.ArgumentParsersallow_abbrevbehaviour - both--joband--job-tokenstarts with--jobchars.Could be fixedhere with:
parser = argparse.ArgumentParser( add_help=add_help, description="GitLab API Command Line Interface",+ allow_abbrev=False )