Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Retry additional http transient errors#1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@Sineaggi
Copy link

@SineaggiSineaggi commentedMar 2, 2022•
edited
Loading

Based off of#1648

This adds additional retries for the 52x caused by cloudflare.

This adds tests for the 52x range and therequests.ConnectionError exception

mitar and f9n reacted with thumbs up emoji
@SineaggiSineaggiforce-pushed theretry-additional-http-transient-errors branch 2 times, most recently from413dd16 to3e6fef1CompareMarch 2, 2022 20:47
@f9n
Copy link

f9n commentedMar 8, 2022

Running perfectly 👍

# On requirements.txtgit+https://github.com/Sineaggi/python-gitlab@retry-additional-http-transient-errors#egg=python-gitlab

Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for taking over@Sineaggi. I just have 2 quick questions here.

@SineaggiSineaggiforce-pushed theretry-additional-http-transient-errors branch 4 times, most recently from4928675 to7f0d3d2CompareMarch 14, 2022 17:50
@SineaggiSineaggi removed their assignmentMar 21, 2022
@Sineaggi
Copy link
Author

@nejch Can you re-review?

@SineaggiSineaggi requested a review fromnejchMarch 21, 2022 19:35
Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks again@Sineaggi, I was on holiday so there was a bit of delay there. I just made one last pass and just noticed some duplicate code. Could you clean that up?

We could probably also make the test code a bit shorter but that's for later perhaps. Thanks!

I'll make sure this makes it into the next release so I can also pause the scheduled release for the 28th until this is merged, if needed.

@nejchnejchforce-pushed theretry-additional-http-transient-errors branch from7f0d3d2 to5cbbf26CompareApril 4, 2022 21:34
@nejchnejchenabled auto-mergeApril 4, 2022 21:36
@nejchnejch merged commit0353bd4 intopython-gitlab:mainApr 4, 2022
gdubicki added a commit to gitlabform/gitlabform that referenced this pull requestFeb 18, 2023
Based onpython-gitlab/python-gitlab#1904(We really need to switch to python-gitlab under the hood...)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nejchnejchnejch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Sineaggi@f9n@nejch@mitar
[8]ページ先頭
©2009-2025 Movatter.jp