- Notifications
You must be signed in to change notification settings - Fork673
test(functional): fix GitLab configuration to support pagination#1881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for fixing this@JohnVillalovos! tiny comment here.
| @@ -244,7 +244,7 @@ def test_project_protected_branches(project): | |||
| def test_project_remote_mirrors(project): | |||
| mirror_url = "http://gitlab.test/root/mirror.git" | |||
| mirror_url = "https://gitlab.com/root/mirror.git" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think push mirrors don't create any requests by default, but just in case:
| mirror_url="https://gitlab.com/root/mirror.git" | |
| mirror_url="https://gitlab.example.com/root/mirror.git" |
(fromhttps://datatracker.ietf.org/doc/html/rfc2606#section-3)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think push mirrors don't create any requests by default, but just in case:
Yeah push mirroring is disabled by default:
https://docs.gitlab.com/ee/api/remote_mirrors.html#create-a-push-mirror
But a good idea to use a non-real host-name. Let me update it and test locally to make sure it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We enable it a few lines down from here, not sure if has any effects still, but just in case. Thanks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah. I wasn't looking at that. Nice that the test works even with a not existing host.
df80cf7 toe6469dfCompareWhen pagination occurs python-gitlab uses the URL provided by theGitLab server to use for the next request.We had previously set the GitLab server configuraiton to say its URLwas `http://gitlab.test` which is not in DNS. Set the hostnamein the URL to `http://127.0.0.1:8080` which is the correct URL for theGitLab server to be accessed while doing functional tests.Closes:#1877
e6469df to5b7d00dCompare
When pagination occurs python-gitlab uses the URL provided by the
GitLab server to use for the next request.
We had previously set the GitLab server configuraiton to say its URL
was
http://gitlab.testwhich is not in DNS. Set the hostnamein the URL to
http://127.0.0.1:8080which is the correct URL for theGitLab server to be accessed while doing functional tests.
Closes:#1877