- Notifications
You must be signed in to change notification settings - Fork674
fix: remove customdelete method for labels#1868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
3870af8 to9c0d7a7Comparecodecov-commenter commentedFeb 1, 2022
Codecov Report
@@ Coverage Diff @@## main #1868 +/- ##==========================================+ Coverage 92.35% 92.41% +0.05%========================================== Files 77 77 Lines 4856 4852 -4 ==========================================- Hits 4485 4484 -1+ Misses 371 368 -3
Flags with carried forward coverage won't be shown.Click here to find out more.
|
Uh oh!
There was an error while loading.Please reload this page.
nejch approved these changesFeb 1, 2022
The usage of deleting was incorrect according to the current API.Remove custom `delete()` method as not needed.Add tests to show it works with labels needing to be encoded.Also enable the test_group_labels() test function. Previously it wasdisabled.Add ability to do a `get()` for group labels.Closes:#1867
9c0d7a7 to0841a2aCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The usage of deleting was incorrect according to the current API.
Remove custom
delete()method as not needed.Add tests to show it works with labels needing to be encoded.
Also enable the test_group_labels() test function. Previously it was
disabled.
Add ability to do a
get()for group labels.Closes:#1867