- Notifications
You must be signed in to change notification settings - Fork675
chore: create new ArrayAttribute class#1866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Create a new ArrayAttribute class. This is to indicate types which aresent to the GitLab server as arrayshttps://docs.gitlab.com/ee/api/#arrayAt this stage it is identical to the CommaSeparatedListAttribute classbut will be used later to support the array types sent to GitLab.This is the second step in a series of steps of our goal to add fullsupport for the GitLab API data types[1]: * array * hash * array of hashesStep one was: commit5127b15[1]https://docs.gitlab.com/ee/api/#encoding-api-parameters-of-array-and-hash-typesRelated:#1698
codecov-commenter commentedJan 30, 2022
Codecov Report
@@ Coverage Diff @@## main #1866 +/- ##======================================= Coverage 92.35% 92.35% ======================================= Files 77 77 Lines 4854 4856 +2 =======================================+ Hits 4483 4485 +2 Misses 371 371
Flags with carried forward coverage won't be shown.Click here to find out more.
|
| "iids":types.CommaSeparatedListAttribute, | ||
| "labels":types.CommaSeparatedListAttribute, | ||
| } | ||
| _types= {"iids":types.ArrayAttribute,"labels":types.CommaSeparatedListAttribute} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lol, this is infuriating:
https://docs.gitlab.com/ee/api/issues.html#list-issues
GET /issues?iids[]=42&iids[]=43GET /issues?labels=foo,bar😁 thanks for going through all the endpoints. I hope the API docs are accurate.
Create a new ArrayAttribute class. This is to indicate types which are
sent to the GitLab server as arrays
https://docs.gitlab.com/ee/api/#array
At this stage it is identical to the CommaSeparatedListAttribute class
but will be used later to support the array types sent to GitLab.
This is the second step in a series of steps of our goal to add full
support for the GitLab API data types[1]:
Step one was: commit5127b15
[1]https://docs.gitlab.com/ee/api/#encoding-api-parameters-of-array-and-hash-types
Related:#1698