- Notifications
You must be signed in to change notification settings - Fork673
Enhance releases API docs for CI_JOB_TOKEN usage#1854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@MRigal for following up on this! Just a small nitpick, and I think commitlint might complain because of the capitilized message, so a little--amend
might be needed :)
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
3ff9d27
to5d973de
CompareThanks@nejch for the review. My bad for the commit format, I had seen the pre-commit configs, but forgot to install the specific hook type, although precisely described here:https://github.com/python-gitlab/python-gitlab/blob/main/CONTRIBUTING.rst#development-workflow Hope this fits the expectation now and hope this can help someone else :-) |
Looks great, thanks again@MRigal! If you find anything else that doesn't make sense feel free to contribute as well! :) |
Fixes#1850
@max-wittig@nejch willing to have a look on it?