Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Enhance releases API docs for CI_JOB_TOKEN usage#1854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

MRigal
Copy link
Contributor

Fixes#1850
@max-wittig@nejch willing to have a look on it?

nejch reacted with thumbs up emoji
Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@MRigal for following up on this! Just a small nitpick, and I think commitlint might complain because of the capitilized message, so a little--amend might be needed :)

@MRigalMRigalforce-pushed thedocs/small-releases-additions branch from3ff9d27 to5d973deCompareJanuary 21, 2022 18:14
@MRigal
Copy link
ContributorAuthor

Thanks@nejch for the review. My bad for the commit format, I had seen the pre-commit configs, but forgot to install the specific hook type, although precisely described here:https://github.com/python-gitlab/python-gitlab/blob/main/CONTRIBUTING.rst#development-workflow

Hope this fits the expectation now and hope this can help someone else :-)

@MRigalMRigal requested a review fromnejchJanuary 21, 2022 18:17
@nejch
Copy link
Member

Looks great, thanks again@MRigal! If you find anything else that doesn't make sense feel free to contribute as well! :)

@nejchnejch merged commitff04900 intopython-gitlab:mainJan 21, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nejchnejchnejch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to access Releases API via CI_JOB_TOKEN
2 participants
@MRigal@nejch

[8]ページ先頭

©2009-2025 Movatter.jp