- Notifications
You must be signed in to change notification settings - Fork673
test: use 'responses' in test_mixins_methods.py#1843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Convert from httmock to responses in test_mixins_methods.pyThis leaves only one file left to convert
| assert isinstance(obj, FakeObject) | ||
| assert obj.foo == "bar" | ||
| assert obj.id ==42 | ||
| assertresponses.assert_call_count(url, 1) is True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As we aren't sharing any fixtures here, was the assert for 1 call intended for all methods or mostly for the one with 2 calls?
Maybe we could splittest_list_mixin intotest_list_mixin andtest_list_mixin_as_generator then to really only test a single scenario per case, and use responses' own assert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we can do that in a follow-up, we still have some httmock anyway.
Convert from httmock to responses in test_mixins_methods.py
This leaves only one file left to convert