- Notifications
You must be signed in to change notification settings - Fork673
chore(objects): useself.encoded_id where applicable#1836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Updated a few remaining usages of `self.id` to use `self.encoded_id`as for the most part we shouldn't be using `self.id`There are now only a few (4 lines of code) remaining uses of`self.id`, most of which seem that they should stay that way.
@nejch Last bit of them... |
codecov-commenter commentedJan 14, 2022
Codecov Report
@@ Coverage Diff @@## main #1836 +/- ##======================================= Coverage 92.25% 92.25% ======================================= Files 77 77 Lines 4839 4839 ======================================= Hits 4464 4464 Misses 375 375
Flags with carried forward coverage won't be shown.Click here to find out more.
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated a few remaining usages of
self.idto useself.encoded_idas for the most part we shouldn't be using
self.idThere are now only a few (4 lines of code) remaining uses of
self.id, most of which seem that they should stay that way.