- Notifications
You must be signed in to change notification settings - Fork676
feat(api): return result fromSaveMixin.save()#1832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@JohnVillalovos I think we want this in the changelog so maybe even |
4ce0a87 to675f587CompareSaveMixin.save()SaveMixin.save()
Sure! Done. |
@kernelport I've marked this as closing#1081 since it implements the rest of your PR. Feel free to reopen the issue if it's not solved after the release. You'll be credited as the author of the commit here. |
fc8cd44 tod90443cCompareReturn the new object data when calling `SaveMixin.save()`.Also remove check for `None` value when calling`self.manager.update()` as that method only returns a dictionary.Closes:#1081
d90443c toe6258a4Comparecodecov-commenter commentedJan 13, 2022
Codecov Report
@@ Coverage Diff @@## main #1832 +/- ##======================================= Coverage 92.20% 92.20% ======================================= Files 77 77 Lines 4834 4834 ======================================= Hits 4457 4457 Misses 377 377
Flags with carried forward coverage won't be shown.Click here to find out more.
|
Uh oh!
There was an error while loading.Please reload this page.
Return the new object data when calling
SaveMixin.save().Also remove check for
Nonevalue when callingself.manager.update()as that method only returns a dictionary.Closes#1081.