NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

fix: use url-encoded ID in all paths (alternate method)#1820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

JohnVillalovos wants to merge1 commit intomainfromjlvillal/encoded_id_alt

Closed

fix: use url-encoded ID in all paths (alternate method)#1820

JohnVillalovos wants to merge1 commit intomainfromjlvillal/encoded_id_alt

Conversation

Copy link

Member

JohnVillalovos commentedJan 9, 2022

An alternative to#1819

Make sure all usage of the ID in the URL path is encoded. Normally it
isn't an issue as most IDs are integers or strings which don't contain
a slash ('/'). But when the ID is a string with a slash character it
will break things.

Add a test case that shows this fixes wikis issue with subpages which
use the slash character.

Closes:#1079

JohnVillalovos force-pushed thejlvillal/encoded_id_alt branch from37dff7e tofd8a747Compare

January 9, 2022 07:20

Copy link

codecov-commenter commentedJan 9, 2022•
edited
Loading

Codecov Report

Merging#1820 (99e1f8b) intomain (ac81272) willincrease coverage by0.08%.
The diff coverage is66.66%.

@@            Coverage Diff             @@##             main    #1820      +/-   ##==========================================+ Coverage   92.10%   92.18%   +0.08%==========================================  Files          76       76                Lines        4801     4826      +25     ==========================================+ Hits         4422     4449      +27+ Misses        379      377       -2

Flag	Coverage Δ
cli_func_v4	`81.37% <26.35%> (+0.01%)`	⬆️
py_func_v4	`80.16% <58.91%> (-0.01%)`	⬇️
unit	`83.23% <34.10%> (+0.19%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
gitlab/v4/objects/epics.py	`74.41% <0.00%> (ø)`
gitlab/v4/objects/features.py	`72.22% <0.00%> (+3.80%)`	⬆️
gitlab/v4/objects/geo_nodes.py	`68.57% <0.00%> (ø)`
gitlab/v4/objects/groups.py	`87.78% <33.33%> (ø)`
gitlab/v4/objects/jobs.py	`77.27% <33.33%> (ø)`
gitlab/v4/objects/projects.py	`87.19% <33.33%> (ø)`
gitlab/v4/objects/repositories.py	`83.07% <55.55%> (ø)`
gitlab/v4/objects/merge_requests.py	`84.78% <62.50%> (ø)`
gitlab/mixins.py	`91.45% <63.15%> (-0.09%)`	⬇️
gitlab/v4/objects/issues.py	`89.02% <66.66%> (ø)`
... and10 more

JohnVillalovos force-pushed thejlvillal/encoded_id_alt branch fromfd8a747 to1df929cCompare

January 9, 2022 07:41

JohnVillalovos marked this pull request as draft

January 9, 2022 07:51

fix: use url-encoded ID in all paths ALTERNATE METHOD

99e1f8b

An alternative to#1819Make sure all usage of the ID in the URL path is encoded. Normally itisn't an issue as most IDs are integers or strings which don't containa slash ('/'). But when the ID is a string with a slash character itwill break things.Add a test case that shows this fixes wikis issue with subpages whichuse the slash character.Closes:#1079