Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: remove custom URL encoding#1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intomainfromjlvillal/remove_replace
Jan 9, 2022
Merged

Conversation

JohnVillalovos
Copy link
Member

@JohnVillalovosJohnVillalovos commentedJan 8, 2022•
edited
Loading

We were usingstr.replace() calls to take care of URL encoding
issues.

Switch them to use ourutils._url_encode() function which itself uses
urllib.parse.quote()

Closes:#1356

@codecov-commenter
Copy link

codecov-commenter commentedJan 8, 2022•
edited
Loading

Codecov Report

Merging#1816 (3d49e5e) intomain (0dba899) willincrease coverage by0.08%.
The diff coverage is88.88%.

@@            Coverage Diff             @@##             main    #1816      +/-   ##==========================================+ Coverage   92.01%   92.10%   +0.08%==========================================  Files          76       76                Lines        4799     4801       +2     ==========================================+ Hits         4416     4422       +6+ Misses        383      379       -4
FlagCoverage Δ
cli_func_v481.35% <38.88%> (-0.04%)⬇️
py_func_v480.17% <77.77%> (+0.09%)⬆️
unit83.04% <38.88%> (-0.04%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/v4/objects/features.py68.42% <0.00%> (-3.81%)⬇️
gitlab/mixins.py91.54% <100.00%> (ø)
gitlab/utils.py88.00% <100.00%> (ø)
gitlab/v4/cli.py81.56% <100.00%> (ø)
gitlab/v4/objects/files.py100.00% <100.00%> (+6.66%)⬆️
gitlab/v4/objects/repositories.py83.07% <100.00%> (ø)

Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks again John! Just a few questions.

@JohnVillalovosJohnVillalovosforce-pushed thejlvillal/remove_replace branch 4 times, most recently fromca85f93 to94dd1e0CompareJanuary 8, 2022 23:43
@nejch
Copy link
Member

As discussed let's call this afix as I think it fixes a few issues including submodule updates for filepaths with dots, if I'm not mistaken.

We were using `str.replace()` calls to take care of URL encodingissues.Switch them to use our `utils._url_encode()` function which itself uses`urllib.parse.quote()`Closes:#1356
@nejchnejch changed the titlechore: remove custom URL encodingfix: remove custom URL encodingJan 9, 2022
@nejchnejch merged commit24d2766 intomainJan 9, 2022
@nejchnejch deleted the jlvillal/remove_replace branchJanuary 9, 2022 00:55
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nejchnejchAwaiting requested review from nejch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of all custom URL encoding
3 participants
@JohnVillalovos@codecov-commenter@nejch
[8]ページ先頭
©2009-2025 Movatter.jp