Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: change tohttp_list for some ProjectCommit methods#1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intomainfromjlvillal/list_api
Jan 8, 2022

Conversation

JohnVillalovos
Copy link
Member

@JohnVillalovosJohnVillalovos commentedJan 6, 2022•
edited
Loading

Fix the type-hints and usehttp_list() for the ProjectCommits methods:

  • diff()
  • merge_requests()
  • refs()

This will enable using the pagination support we have for lists.

Closes:#1805
Closes:#1231

@codecov-commenter
Copy link

codecov-commenter commentedJan 6, 2022•
edited
Loading

Codecov Report

Merging#1809 (8b4f500) intomain (a349793) willincrease coverage by0.00%.
The diff coverage is100.00%.

@@           Coverage Diff           @@##             main    #1809   +/-   ##=======================================  Coverage   92.02%   92.02%           =======================================  Files          76       76             Lines        4790     4791    +1     =======================================+ Hits         4408     4409    +1  Misses        382      382
FlagCoverage Δ
cli_func_v481.38% <50.00%> (+<0.01%)⬆️
py_func_v480.21% <100.00%> (+<0.01%)⬆️
unit83.19% <50.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/v4/objects/commits.py94.73% <100.00%> (+0.07%)⬆️
gitlab/v4/objects/services.py100.00% <0.00%> (ø)

@nejch
Copy link
Member

@JohnVillalovos I'd say this is a proper fix and not a chore especially as it fixes that older issue as well, could you change the commit message so we can trigger a fix release?

Fix the type-hints and use `http_list()` for the ProjectCommits methods:   - diff()   - merge_requests()   - refs()This will enable using the pagination support we have for lists.Closes:#1805Closes:#1231
@JohnVillalovosJohnVillalovos changed the titlechore: fix type-hints for ProjectCommit methodsfix: change tohttp_list for some ProjectCommit methodsJan 8, 2022
@JohnVillalovos
Copy link
MemberAuthor

@JohnVillalovos I'd say this is a proper fix and not a chore especially as it fixes that older issue as well, could you change the commit message so we can trigger a fix release?

Done!

@nejchnejchenabled auto-mergeJanuary 8, 2022 20:28
@nejchnejch merged commitd45b59e intomainJan 8, 2022
@nejchnejch deleted the jlvillal/list_api branchJanuary 8, 2022 20:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nejchnejchAwaiting requested review from nejch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong return type annotation in ProjectCommit.refs() Unable to get page count info when calling commit.diff()
3 participants
@JohnVillalovos@codecov-commenter@nejch
[8]ページ先頭
©2009-2025 Movatter.jp