- Notifications
You must be signed in to change notification settings - Fork676
test: reproduce missing pagination headers in tests#1788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
b43927c to0c92300CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me.
Left a nit. But good to merge for me.
| importpickle | ||
| importwarnings | ||
| fromcopyimportdeepcopy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit: My personal taste isimport copy and then usecopy.deepcopy() as when reading the code quickly know where it comes from.
Built on top of#1787.
I tried parametrizing tests at first but this seemed cleaner in the end, it would get overly complicated because ofpytest-dev/pytest#349.