- Notifications
You must be signed in to change notification settings - Fork674
chore: fixtures: after delete() wait to verify deleted#1784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
d684c74 tob0b137aCompareb0b137a to05c1240Compare05c1240 to3633850CompareJohnVillalovos commentedJun 30, 2022
Example of error in tests that this is trying to fix: |
JohnVillalovos commentedJul 1, 2022
nejch commentedJul 1, 2022
Thanks@JohnVillalovos I'll try to get back into the functional testing topic a bit.. I think we should make this reliable for sure, although it also shows we have some poor assertions in those legacy tests there. IMO we should never be asserting |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
3633850 tof4b2373Comparef4b2373 to75be3aaCompare80122a7 to7a86c8dCompare7a86c8d to41f94ebCompare41f94eb to7b946d2CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
1dcf0f4 tob8d3aa5Comparenejch commentedJul 21, 2022
Thanks again@JohnVillalovos, just a few more random thoughts as I like that we're potentially even reducing the codebase here :) |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
In our fixtures that create: - groups - project merge requests - projects - usersThey delete the created objects after use. Now wait to ensure theobjects are deleted before continuing as having unexpected objectsexisting can impact some of our tests.
b8d3aa5 to1f73b6bCompareUh oh!
There was an error while loading.Please reload this page.
In our fixtures that create:
They delete the created objects after use. Now wait to ensure the
objects are deleted before continuing as having unexpected objects
existing can impact some of our tests.