From the RFC:
For consistency, percent-encoded octets in the ranges of ALPHA
(%41-%5A and %61-%7A), DIGIT (%30-%39), hyphen (%2D), period (%2E),
underscore (%5F), or tilde (%7E) should not be created by URI
producers...

Closes#1006
Related#1356
Related#1561

BREAKING CHANGE: stop encoding '.' to '%2E'. This could potentially be
a breaking change for users who have incorrectly configured GitLab
servers which don't handle period '.' characters correctly.

JohnVillalovos marked this pull request as draft

December 19, 2021 23:23

JohnVillalovos force-pushed thejlvillal/leave_dot branch 2 times, most recently from950b7ba tod12b829Compare

December 19, 2021 23:38

Copy link

codecov-commenter commentedDec 19, 2021•
edited by codecovbot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base(ccefe80) to head(702e41d).
Report is 1215 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main    #1766      +/-   ##==========================================- Coverage   91.97%   91.95%   -0.02%==========================================  Files          76       76                Lines        4759     4751       -8     ==========================================- Hits         4377     4369       -8  Misses        382      382

Flag	Coverage Δ
cli_func_v4	`81.30% <100.00%> (-0.04%)`	⬇️
py_func_v4	`80.67% <100.00%> (-0.04%)`	⬇️
unit	`83.20% <100.00%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
gitlab/client.py	`90.00% <100.00%> (-0.11%)`	⬇️
gitlab/utils.py	`88.00% <100.00%> (-1.66%)`	⬇️

JohnVillalovos force-pushed thejlvillal/leave_dot branch fromd12b829 tof6066c7Compare

December 19, 2021 23:49

JohnVillalovos changed the title~~Jlvillal/leave dot~~chore: stop encoding '.' to '%2E'

Dec 19, 2021

JohnVillalovos force-pushed thejlvillal/leave_dot branch fromf6066c7 toca0e183Compare

December 19, 2021 23:51

JohnVillalovos marked this pull request as ready for review

December 19, 2021 23:52

JohnVillalovos force-pushed thejlvillal/leave_dot branch 2 times, most recently fromd7893c1 to39155dfCompare

December 20, 2021 00:15

JohnVillalovos mentioned this pull request

Dec 20, 2021

feat(api): support file format for repository archive#1561

Merged

Copy link

Member

nejch commentedDec 20, 2021

@JohnVillalovos could you make this afix type so it shows in the release and also add thestop encoding '.' to '%2E' sentence at the beginning of the breaking change trailer so it's clear in the release notes in the breaking changes list?

JohnVillalovos force-pushed thejlvillal/leave_dot branch from39155df todaa2e65Compare

December 20, 2021 21:59

Copy link

MemberAuthor

JohnVillalovos commentedDec 20, 2021

@JohnVillalovos could you make this afix type so it shows in the release and also add thestop encoding '.' to '%2E' sentence at the beginning of the breaking change trailer so it's clear in the release notes in the breaking changes list?

Done I think. Thanks.

nejch reviewed

Dec 20, 2021

View reviewed changes

gitlab/client.pyShow resolvedHide resolved

fix: stop encoding '.' to '%2E'

702e41d

Forcing the encoding of '.' to '%2E' causes issues. It also goesagainst the RFC:https://datatracker.ietf.org/doc/html/rfc3986.html#section-2.3From the RFC:  For consistency, percent-encoded octets in the ranges of ALPHA  (%41-%5A and %61-%7A), DIGIT (%30-%39), hyphen (%2D), period (%2E),  underscore (%5F), or tilde (%7E) should not be created by URI  producers...Closes#1006Related#1356Related#1561BREAKING CHANGE: stop encoding '.' to '%2E'. This could potentially bea breaking change for users who have incorrectly configured GitLabservers which don't handle period '.' characters correctly.