- Notifications
You must be signed in to change notification settings - Fork673
feat(cli): do not require config file to run CLI#1743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-commenter commentedDec 12, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #1743 +/- ##==========================================- Coverage 91.97% 91.97% -0.01%========================================== Files 76 76 Lines 4737 4759 +22 ==========================================+ Hits 4357 4377 +20- Misses 380 382 +2
Flags with carried forward coverage won't be shown.Click here to find out more.
|
Uh oh!
There was an error while loading.Please reload this page.
8884417 tod0c6005CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can functional tests be added for this. In particular a functional test that demonstrates it works without a config file? Though I guess that will try to contacthttps://gitlab.com/ 😟
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
d0c6005 toe6449d3CompareBREAKING CHANGE: A config file is no longer needed to runthe CLI. python-gitlab will default tohttps://gitlab.comwith no authentication if there is no config file provided.python-gitlab will now also only look for configurationin the provided PYTHON_GITLAB_CFG path, instead of mergingit with user- and system-wide config files. If theenvironment variable is defined and the file cannot beopened, python-gitlab will now explicitly fail.
e6449d3 to92a893bCompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me. I wasn't sure if you wanted to merge it or not.
Please merge whenever you are ready.
Thanks.
Uh oh!
There was an error while loading.Please reload this page.
BREAKING CHANGE: A config file is no longer needed to run
the CLI. python-gitlab will default tohttps://gitlab.com
with no authentication if there is no config file provided.
python-gitlab will now also only look for configuration
in the provided PYTHON_GITLAB_CFG path, instead of merging
it with user- and system-wide config files. If the
environment variable is defined and the file cannot be
opened, python-gitlab will now explicitly fail.
Needed for#1296