Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: package file delete on package file object#1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intopython-gitlab:mainfromshebertd:fix-package-file-delete
Dec 10, 2021
Merged

feat: package file delete on package file object#1733

nejch merged 1 commit intopython-gitlab:mainfromshebertd:fix-package-file-delete
Dec 10, 2021

Conversation

shebertd
Copy link

No description provided.

@codecov-commenter
Copy link

codecov-commenter commentedDec 6, 2021
edited
Loading

Codecov Report

Merging#1733 (124667b) intomain (4945353) willnot change coverage.
The diff coverage is100.00%.

@@           Coverage Diff           @@##             main    #1733   +/-   ##=======================================  Coverage   91.95%   91.95%           =======================================  Files          75       75             Lines        4689     4689           =======================================  Hits         4312     4312             Misses        377      377
FlagCoverage Δ
cli_func_v481.40% <100.00%> (ø)
py_func_v480.93% <100.00%> (ø)
unit83.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/v4/objects/packages.py96.29% <100.00%> (ø)

@JohnVillalovos
Copy link
Member

Thanks. Would you be willing to add a test case for this? Probably intests/functional/api/test_packages.py would be good.

shebertd reacted with thumbs up emoji

@shebertd
Copy link
Author

@JohnVillalovos I will!

@shebertdshebertd changed the titlefix package file deletefeat: package file delete on package file objectDec 8, 2021
@shebertd
Copy link
Author

@JohnVillalovos I've added a unit tests and classified the merge as afeat.

JohnVillalovos reacted with thumbs up emoji

@shebertd
Copy link
Author

@JohnVillalovos I've fixed my test. I like the setup of the project with commitlint.

@JohnVillalovos
Copy link
Member

Thanks. As a note for the future. It can sometimes be simpler to do the tests in thetests/functional/api/ directory as those actually run against a running Gitlab instance.

But thanks for the unit tests!

@shebertd
Copy link
Author

Thanks for your precious time. I will note that! As a fact I will revisit the functional test in the future to help me learn pytest and be more confident in the delete at the same time.

My delete is'nt a great test because it only test if it does'nt work, but not if it works.

@nejch
Copy link
Member

Thank you very much @simonisateur!

@nejchnejch merged commit2f37ccb intopython-gitlab:mainDec 10, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JohnVillalovosJohnVillalovosJohnVillalovos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@shebertd@codecov-commenter@JohnVillalovos@nejch

[8]ページ先頭

©2009-2025 Movatter.jp