- Notifications
You must be signed in to change notification settings - Fork673
feat: package file delete on package file object#1733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-commenter commentedDec 6, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #1733 +/- ##======================================= Coverage 91.95% 91.95% ======================================= Files 75 75 Lines 4689 4689 ======================================= Hits 4312 4312 Misses 377 377
Flags with carried forward coverage won't be shown.Click here to find out more.
|
Thanks. Would you be willing to add a test case for this? Probably in |
@JohnVillalovos I will! |
@JohnVillalovos I've added a unit tests and classified the merge as a |
@JohnVillalovos I've fixed my test. I like the setup of the project with commitlint. |
Uh oh!
There was an error while loading.Please reload this page.
Thanks. As a note for the future. It can sometimes be simpler to do the tests in the But thanks for the unit tests! |
Thanks for your precious time. I will note that! As a fact I will revisit the functional test in the future to help me learn pytest and be more confident in the delete at the same time. My delete is'nt a great test because it only test if it does'nt work, but not if it works. |
Thank you very much @simonisateur! |
No description provided.