- Notifications
You must be signed in to change notification settings - Fork673
chore: add initial pylint check#1729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
9a9c10a toddc24beComparecodecov-commenter commentedDec 5, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #1729 +/- ##==========================================- Coverage 92.03% 92.03% -0.01%========================================== Files 75 75 Lines 4683 4681 -2 ==========================================- Hits 4310 4308 -2 Misses 373 373
Flags with carried forward coverage won't be shown.Click here to find out more.
|
ddc24be todf93b20CompareUh oh!
There was an error while loading.Please reload this page.
df93b20 toda5f43fCompareUh oh!
There was an error while loading.Please reload this page.
de14dea to5f35250CompareUh oh!
There was an error while loading.Please reload this page.
dde09fc to168d2abCompareInitial pylint check is added. A LONG list of disabled checks is alsoadded. In the future we should work through the list and resolve theerrors or disable them on a more granular level.
If .pre-commit-config.yaml or .github/workflows/pre_commit.yml areupdated then run pre-commit.
cb61379 to645ef1fComparehttps://github.com/pre-commit/mirrors-mypy/blob/master/.pre-commit-hooks.yamlSets some default args which seem to be interfering with things. Pluswe set all of our args in the `pyproject.toml` file.
645ef1f tob67a6adCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial pylint check is added. A LONG list of disabled checks is also
added. In the future we should work through the list and resolve the
errors or disable them on a more granular level.