- Notifications
You must be signed in to change notification settings - Fork674
chore: remove pytest-console-scripts specific config#1714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
2a71da0 toa2f7996Compare
nejch left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@JohnVillalovos just a quick note :)
Uh oh!
There was an error while loading.Please reload this page.
0546f66 to2ef0b5bCompareJohnVillalovos commentedNov 25, 2021
@nejch Thanks for the info above. If you have any ideas why my change is failing it would be appreciated. I guess I could just drop using the decorator as it seems to work okay without it. But I think it is using "in-process" mode by default instead of "subprocess" mode. Not sure if that matters or not. |
b598568 to05ea611CompareJohnVillalovos commentedNov 25, 2021
@nejch I got it figured out. Ready for review. Thanks. |
nejch commentedNov 27, 2021
Thanks@JohnVillalovos. I hope my comment wasn't too confusing. What you did in [testenv:cli_func_v4]deps = -r{toxinidir}/requirements-docker.txtcommands = pytest --script-launch-mode=subprocess --cov --cov-report xml tests/functional/cli {posargs} and it would work (but omit it for py_func_v4). The reason I added subprocess mode initially I think was because it would more closely resemble the environment of a user running the CLI I believe. |
Remove the pytest-console-scripts specific config from the global'[pytest]' config section.Use the command line option `--script-launch-mode=subprocess`Closes#1713
05ea611 toe80dcb1CompareJohnVillalovos commentedNov 27, 2021
Thanks@nejch When I got the error before when using the command line argument |
Remove the pytest-console-scripts specific config from the global
'[pytest]' config section.
Move it to a command line option for the functional tests which use
the Docker container.
Closes#1713