Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(api): add support for epic notes#1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intopython-gitlab:mainfromStingRayZA:Epicnotes
Nov 27, 2021

Conversation

StingRayZA
Copy link
Contributor

Added support for notes/emojis/discussions on group epics

(also fixedProjectSnippetNote to use the correctAwardEmojiManager)

Added support for notes on group epicsSigned-off-by: Raimund Hook <raimund.hook@exfo.com>
@codecov-commenter
Copy link

Codecov Report

Merging#1712 (7f4edb5) intomain (3225f2c) willdecrease coverage by0.01%.
The diff coverage is89.74%.

@@            Coverage Diff             @@##             main    #1712      +/-   ##==========================================- Coverage   91.49%   91.47%   -0.02%==========================================  Files          75       75                Lines        4630     4668      +38     ==========================================+ Hits         4236     4270      +34- Misses        394      398       +4
FlagCoverage Δ
cli_func_v480.69% <89.74%> (+0.07%)⬆️
py_func_v480.95% <89.74%> (+0.06%)⬆️
unit82.96% <89.74%> (+0.05%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/v4/objects/award_emojis.py89.47% <88.88%> (-0.19%)⬇️
gitlab/v4/objects/notes.py94.23% <90.47%> (-1.01%)⬇️

Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks again@StingRayZA. Was gonna say it would be cool to have tests but I see we have none for these things plus it's a Premium feature. :)

StingRayZA reacted with thumbs up emoji
@nejchnejch merged commit70b9870 intopython-gitlab:mainNov 27, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JohnVillalovosJohnVillalovosJohnVillalovos approved these changes

@nejchnejchnejch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@StingRayZA@codecov-commenter@JohnVillalovos@nejch

[8]ページ先頭

©2009-2025 Movatter.jp