- Notifications
You must be signed in to change notification settings - Fork674
chore: add get() methods for GetWithoutIdMixin based classes#1710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2f550e2 tod79ff6aComparecodecov-commenter commentedNov 24, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #1710 +/- ##==========================================- Coverage 91.95% 91.94% -0.02%========================================== Files 75 75 Lines 4689 4719 +30 ==========================================+ Hits 4312 4339 +27- Misses 377 380 +3
Flags with carried forward coverage won't be shown.Click here to find out more.
|
d79ff6a to2e9cbdaCompare2e9cbda toab82fd8Compare33b2d56 to1453601Compare1453601 to46f4d1aCompareUh oh!
There was an error while loading.Please reload this page.
Add the get() methods for the GetWithoutIdMixin based classes.Update the tests/meta/test_ensure_type_hints.py tests to check toensure that the get methods are defined with the correct return type.
46f4d1a tod27c50aCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the get() methods for the GetWithoutIdMixin based classes.
Update the tests/meta/test_ensure_type_hints.py tests to check to
ensure that the get methods are defined with the correct return type.