Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: attempt to be more informative for missing attributes#1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intomainfromjlvillal/attribute_help
Dec 1, 2021

Conversation

@JohnVillalovos
Copy link
Member

@JohnVillalovosJohnVillalovos commentedNov 20, 2021•
edited
Loading

A commonly reported issue from users on Gitter is that they get an
AttributeError for an attribute that should be present. This is often
caused due to the fact that they used thelist() method to retrieve
the object and objects retrieved this way often only have a subset of
the full data.

Add more details in the AttributeError message that explains the
situation to users. This will hopefully allow them to resolve the
issue.

Closes#1138

nejch reacted with heart emoji
@codecov-commenter
Copy link

codecov-commenter commentedNov 21, 2021•
edited
Loading

Codecov Report

Merging#1702 (1839c9e) intomain (09a973e) willincrease coverage by0.01%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #1702      +/-   ##==========================================+ Coverage   92.01%   92.02%   +0.01%==========================================  Files          75       75                Lines        4670     4677       +7     ==========================================+ Hits         4297     4304       +7  Misses        373      373
FlagCoverage Δ
cli_func_v481.44% <83.33%> (+<0.01%)⬆️
py_func_v481.05% <58.33%> (-0.04%)⬇️
unit83.19% <100.00%> (+0.02%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/base.py90.22% <100.00%> (+0.40%)⬆️
gitlab/mixins.py91.54% <100.00%> (ø)

@nejch
Copy link
Member

This will also close#1138.

JohnVillalovos and MrMino reacted with thumbs up emojiJohnVillalovos reacted with hooray emoji

Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@JohnVillalovos, just a few small notes from me.

I was thinking something similar for missing methods in e.g.Issue vsProjectIssue to guide users towards creating the right objects or even give amake_editable() method for those to convert them. So I really like it and would maybe build on this later as well. I think there might also be a few other cases where this could be extended later, such as after running save/update and so on.

@JohnVillalovos
Copy link
MemberAuthor

Thanks@JohnVillalovos, just a few small notes from me.

I was thinking something similar for missing methods in e.g.Issue vsProjectIssue to guide users towards creating the right objects or even give amake_editable() method for those to convert them. So I really like it and would maybe build on this later as well. I think there might also be a few other cases where this could be extended later, such as after running save/update and so on.

Thanks for the review! Will work on updating the PR.

I like the idea of catching the common issues that users of the library encounter and trying to point them to how to fix it so they file less issues 😊

@JohnVillalovosJohnVillalovosforce-pushed thejlvillal/attribute_help branch 2 times, most recently from644ef29 to6c5fe03CompareNovember 27, 2021 17:32
A commonly reported issue from users on Gitter is that they get anAttributeError for an attribute that should be present. This is oftencaused due to the fact that they used the `list()` method to retrievethe object and objects retrieved this way often only have a subset ofthe full data.Add more details in the AttributeError message that explains thesituation to users. This will hopefully allow them to resolve theissue.Update the FAQ in the docs to add a section discussing the issue.Closes#1138
@nejchnejch merged commit387e59f intomainDec 1, 2021
@nejchnejch deleted the jlvillal/attribute_help branchDecember 1, 2021 00:32
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nejchnejchnejch requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ProjectPipeline from.list(as_list=False) has fewer information than the one from.get(id)

4 participants

@JohnVillalovos@codecov-commenter@nejch
[8]ページ先頭
©2009-2025 Movatter.jp