- Notifications
You must be signed in to change notification settings - Fork673
chore: add type-hints to remaining gitlab/v4/objects/*.py files#1695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
57cd034 tobb1a454Comparecodecov-commenter commentedNov 17, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #1695 +/- ##==========================================- Coverage 91.53% 91.46% -0.08%========================================== Files 75 75 Lines 4574 4616 +42 ==========================================+ Hits 4187 4222 +35- Misses 387 394 +7
Flags with carried forward coverage won't be shown.Click here to find out more.
|
Uh oh!
There was an error while loading.Please reload this page.
bb1a454 tofbf2bfeCompare1ecb0a6 toccd93e3Comparecf0049b tod18987fCompareWhen attempting to add type-hints to the the 'manager' attribute intoa RESTObject derived class it would break things.This was because our auto-manager creation code would automaticallyadd the specified annotated manager to the 'manager' attribute. Thisbreaks things.Now check in our auto-manager creation if our attribute is called'manager'. If so we ignore it.
d18987f to0c22bd9Compare This was linked to issuesNov 22, 2021
Closed
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixed a bug in the auto-manager creation code if we added a type-hint for the
managerattribute.Add type-hints for the remainder of the code base.
Finally! 😊