- Notifications
You must be signed in to change notification settings - Fork673
Ensure get() methods have correct type-hints#1681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I like the idea so that people get a helpful message to guide them, because this can get quite complex for new contributors I think.
For me this (andtest_mro.py
) are kind of almost meta tests, so I wonder if we should move them together withtest_dists.py
or so (all the other modules inobjects/
really test functions on gitlab resources).
Uh oh!
There was an error while loading.Please reload this page.
3df0d8a
to8fcec4b
Compare8fcec4b
to196c6e1
CompareJohnVillalovos commentedNov 9, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Moving them works for me. I had put them in If we move them, where do you think we should move them. |
196c6e1
to5e54d67
Compare5e54d67
toc78e9de
Compare
I was thinking maybehttps://github.com/python-gitlab/python-gitlab/tree/main/tests/smoke along with |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
42726c9
toae68668
Compare
I created a new |
b14212b
to7910780
Comparecodecov-commenter commentedNov 15, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #1681 +/- ##==========================================- Coverage 91.88% 91.55% -0.33%========================================== Files 75 75 Lines 4435 4571 +136 ==========================================+ Hits 4075 4185 +110- Misses 360 386 +26
Flags with carried forward coverage won't be shown.Click here to find out more.
|
The 'test_mro.py' file is not really a unit test but more of a 'meta'check on the validity of the code base.
Fix classes which don't have correct 'get()' methods for classesderived from GetMixin.Add a unit test which verifies that classes have the correct returntype in their 'get()' method.
7910780
to46773a8
Compare
Uh oh!
There was an error while loading.Please reload this page.
Fix classes which don't have correct 'get()' methods for classes
derived from GetMixin.
Add a unit test which verifies that classes have the correct return
type in their 'get()' method.