Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add type-hints to multiple files in gitlab/v4/objects/#1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intomainfromjlvillal/mypy_small_files_1
Nov 7, 2021

Conversation

JohnVillalovos
Copy link
Member

@JohnVillalovosJohnVillalovos commentedNov 7, 2021
edited
Loading

Add and/or check type-hints for the following files
gitlab.v4.objects.access_requests
gitlab.v4.objects.applications
gitlab.v4.objects.broadcast_messages
gitlab.v4.objects.deployments
gitlab.v4.objects.keys
gitlab.v4.objects.merge_trains
gitlab.v4.objects.namespaces
gitlab.v4.objects.pages
gitlab.v4.objects.personal_access_tokens
gitlab.v4.objects.project_access_tokens
gitlab.v4.objects.tags
gitlab.v4.objects.templates
gitlab.v4.objects.triggers

Add a 'get' method with the correct type for Managers derived from
GetMixin.

@codecov-commenter
Copy link

codecov-commenter commentedNov 7, 2021
edited
Loading

Codecov Report

Merging#1674 (8b75a77) intomain (f3688dc) willdecrease coverage by0.02%.
The diff coverage is88.23%.

@@            Coverage Diff             @@##             main    #1674      +/-   ##==========================================- Coverage   91.97%   91.95%   -0.03%==========================================  Files          75       75                Lines        4351     4364      +13     ==========================================+ Hits         4002     4013      +11- Misses        349      351       +2
FlagCoverage Δ
cli_func_v481.85% <64.70%> (-0.04%)⬇️
py_func_v481.18% <88.23%> (+0.01%)⬆️
unit83.63% <76.47%> (-0.05%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/v4/objects/namespaces.py91.66% <66.66%> (-8.34%)⬇️
gitlab/v4/objects/triggers.py92.85% <66.66%> (-7.15%)⬇️
gitlab/v4/objects/broadcast_messages.py100.00% <100.00%> (ø)
gitlab/v4/objects/keys.py100.00% <100.00%> (ø)
gitlab/v4/objects/merge_trains.py100.00% <100.00%> (ø)
gitlab/v4/objects/pages.py100.00% <100.00%> (ø)

Add and/or check type-hints for the following files    gitlab.v4.objects.access_requests    gitlab.v4.objects.applications    gitlab.v4.objects.broadcast_messages    gitlab.v4.objects.deployments    gitlab.v4.objects.keys    gitlab.v4.objects.merge_trains    gitlab.v4.objects.namespaces    gitlab.v4.objects.pages    gitlab.v4.objects.personal_access_tokens    gitlab.v4.objects.project_access_tokens    gitlab.v4.objects.tags    gitlab.v4.objects.templates    gitlab.v4.objects.triggersAdd a 'get' method with the correct type for Managers derived fromGetMixin.
@JohnVillalovosJohnVillalovosforce-pushed thejlvillal/mypy_small_files_1 branch from288121d to8b75a77CompareNovember 7, 2021 20:36
@nejchnejch merged commitcf801d8 intomainNov 7, 2021
@nejchnejch deleted the jlvillal/mypy_small_files_1 branchNovember 7, 2021 21:55
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nejchnejchAwaiting requested review from nejch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@JohnVillalovos@codecov-commenter@nejch

[8]ページ先頭

©2009-2025 Movatter.jp