Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add type-hints to gitlab/v4/objects/groups.py#1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intomainfromjlvillal/mypy_groups
Nov 7, 2021

Conversation

@JohnVillalovos
Copy link
Member

@JohnVillalovosJohnVillalovos commentedNov 6, 2021•
edited
Loading

 * Add type-hints to gitlab/v4/objects/groups.py * Add return value to share() function as GitLab docs show it returns   a value. * Add 'get()' method so that type-checkers will understand that   getting a group is of type Group.

@JohnVillalovosJohnVillalovos changed the titleWIP: Add type-hints to gitlab/v4/objects/groups.pychore: add type-hints to gitlab/v4/objects/groups.pyNov 6, 2021
@codecov-commenter
Copy link

codecov-commenter commentedNov 6, 2021•
edited
Loading

Codecov Report

Merging#1668 (65f2bea) intomain (4ab9e92) willincrease coverage by0.01%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #1668      +/-   ##==========================================+ Coverage   91.99%   92.01%   +0.01%==========================================  Files          75       75                Lines        4337     4343       +6     ==========================================+ Hits         3990     3996       +6  Misses        347      347
FlagCoverage Δ
cli_func_v481.92% <88.23%> (+<0.01%)⬆️
py_func_v481.18% <100.00%> (+0.02%)⬆️
unit83.72% <88.23%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/v4/objects/groups.py87.78% <100.00%> (+0.58%)⬆️

Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks again@JohnVillalovos just one little question :)

@JohnVillalovosJohnVillalovosforce-pushed thejlvillal/mypy_groups branch 2 times, most recently from9cb07b3 to65f2beaCompareNovember 6, 2021 18:23
 * Add type-hints to gitlab/v4/objects/groups.py * Have share() function update object attributes. * Add 'get()' method so that type-checkers will understand that   getting a group is of type Group.
@nejchnejch merged commitf3688dc intomainNov 7, 2021
@nejchnejch deleted the jlvillal/mypy_groups branchNovember 7, 2021 20:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nejchnejchAwaiting requested review from nejch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JohnVillalovos@codecov-commenter@nejch
[8]ページ先頭
©2009-2025 Movatter.jp