Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(api): add project milestone promotion#1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intopython-gitlab:mainfromStingRayZA:add-milestone-promote
Oct 31, 2021

Conversation

StingRayZA
Copy link
Contributor

Adds promotion to Project Milestones

Fixes#1654

Adds promotion to Project MilestonesSigned-off-by: Raimund Hook <raimund.hook@exfo.com>
@codecov-commenter
Copy link

codecov-commenter commentedOct 27, 2021
edited
Loading

Codecov Report

Merging#1655 (f068520) intomain (0b53c0a) willincrease coverage by0.02%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #1655      +/-   ##==========================================+ Coverage   91.95%   91.97%   +0.02%==========================================  Files          74       74                Lines        4323     4324       +1     ==========================================+ Hits         3975     3977       +2+ Misses        348      347       -1
FlagCoverage Δ
cli_func_v481.86% <100.00%> (+<0.01%)⬆️
py_func_v481.10% <100.00%> (+0.02%)⬆️
unit83.67% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/v4/objects/milestones.py100.00% <100.00%> (ø)
gitlab/mixins.py91.54% <0.00%> (+0.24%)⬆️

Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@StingRayZA looks good, and the PromoteMixin does make sense now.

A group project fixture (instead of personal ones) might be useful in the future if we do more of this.

@nejchnejch merged commit5ce3b17 intopython-gitlab:mainOct 31, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nejchnejchnejch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Support Milestone Promotion
3 participants
@StingRayZA@codecov-commenter@nejch

[8]ページ先頭

©2009-2025 Movatter.jp