Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(docs):API delete key example#1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JohnVillalovos merged 1 commit intopython-gitlab:mainfrombengaywins:main
Oct 12, 2021
Merged

fix(docs):API delete key example#1638

JohnVillalovos merged 1 commit intopython-gitlab:mainfrombengaywins:main
Oct 12, 2021

Conversation

bengaywins
Copy link

Closes#1637

@bengaywinsbengaywins changed the titleFix API delete key examplefix(docs):API delete key exampleOct 12, 2021
@JohnVillalovos
Copy link
Member

The commit message will need to be like:

docs: fix API delete key example

@bengaywins
Copy link
Author

Ah I was trying to make sense of that. Just pushed again withdocs: prefix.

@JohnVillalovos
Copy link
Member

Ah I was trying to make sense of that. Just pushed again withdocs: prefix.

I think it catches everyone the first time.

I actually do agit log to remind myself of the format 😏

bengaywins reacted with laugh emoji

@bengaywins
Copy link
Author

must not be sentence-case, start-case, pascal-case, upper-case

Does this mean that the entire commit message must be all lowercase?

@JohnVillalovos
Copy link
Member

must not be sentence-case, start-case, pascal-case, upper-case

Does this mean that the entire commit message must be all lowercase?

No. Just the first letter after the colon. Try the message I suggested above. I believe that will work.

@bengaywins
Copy link
Author

Awesome just pushed with said commit message.

@bengaywins
Copy link
Author

Also really appreciate the help@JohnVillalovos!

JohnVillalovos reacted with heart emoji

@JohnVillalovos
Copy link
Member

Thanks! LGTM (Looks Good To Me).

bengaywins reacted with rocket emoji

@JohnVillalovosJohnVillalovosenabled auto-merge (rebase)October 12, 2021 18:00
@codecov-commenter
Copy link

codecov-commenter commentedOct 12, 2021
edited
Loading

Codecov Report

Merging#1638 (7adab7a) intomain (4eb8ec8) willdecrease coverage by3.89%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #1638      +/-   ##==========================================- Coverage   91.90%   88.01%   -3.90%==========================================  Files          74       74                Lines        4287     4287              ==========================================- Hits         3940     3773     -167- Misses        347      514     +167
FlagCoverage Δ
cli_func_v481.89% <ø> (ø)
py_func_v4?
unit83.71% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/v4/objects/files.py61.76% <0.00%> (-30.89%)⬇️
gitlab/v4/objects/milestones.py71.42% <0.00%> (-28.58%)⬇️
gitlab/utils.py65.51% <0.00%> (-24.14%)⬇️
gitlab/v4/objects/repositories.py57.62% <0.00%> (-23.73%)⬇️
gitlab/v4/objects/sidekiq.py80.95% <0.00%> (-19.05%)⬇️
gitlab/v4/objects/commits.py78.87% <0.00%> (-15.50%)⬇️
gitlab/v4/objects/clusters.py85.71% <0.00%> (-14.29%)⬇️
gitlab/v4/objects/snippets.py83.72% <0.00%> (-13.96%)⬇️
gitlab/v4/objects/environments.py88.23% <0.00%> (-11.77%)⬇️
gitlab/v4/objects/merge_requests.py76.19% <0.00%> (-9.53%)⬇️
... and10 more

@JohnVillalovosJohnVillalovos merged commitb31bb05 intopython-gitlab:mainOct 12, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JohnVillalovosJohnVillalovosJohnVillalovos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] Documentation bug
3 participants
@bengaywins@JohnVillalovos@codecov-commenter

[8]ページ先頭

©2009-2025 Movatter.jp