Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: renamemaster branch tomain#1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intomainfromchore/master-to-main
Oct 12, 2021
Merged

chore: renamemaster branch tomain#1629

nejch merged 1 commit intomainfromchore/master-to-main
Oct 12, 2021

Conversation

nejch
Copy link
Member

@nejchnejch commentedOct 9, 2021
edited
Loading

BREAKING CHANGE: As of python-gitlab 3.0.0, the default branch for development
has changed frommaster tomain.

GitHub changed on 1-10-2020, GitLab changed with 14.0.

Closes#1622.Will switch the branch in the project first before assigning this. Switched to main and pushed master again to have an old branch in case some people relied on it.

@nejchnejch mentioned this pull requestOct 9, 2021
15 tasks
@nejchnejchforce-pushed thechore/master-to-main branch 2 times, most recently from86255ca to14fb924CompareOctober 9, 2021 13:54
@nejchnejch marked this pull request as ready for reviewOctober 9, 2021 14:47
Copy link
Member

@JohnVillalovosJohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fine with me and would also be fine ifmaster disappeared to remove the chance of confusion.

@JohnVillalovos
Copy link
Member

Also a thought. If decide to keepmaster maybe put in a final commit which deletes everything and directs people to use themain branch. Thenmaster branch exists but won't cause confusion for people.

@nejch
Copy link
MemberAuthor

Fine with me and would also be fine ifmaster disappeared to remove the chance of confusion.

That makes sense also, I'll see what other projects do but I think we can just remove it shortly after releasing and not keep stale branches

BREAKING CHANGE: As of python-gitlab 3.0.0, the default branch for developmenthas changed from `master` to `main`.
@nejch
Copy link
MemberAuthor

@JohnVillalovos I've removed the references to keeping an old master, I just remembered I also had some confusion while rebasing on the wrong branch with a project that kept it.. we can remove it after the release :P

@nejchnejch merged commit63b2070 intomainOct 12, 2021
@nejchnejch deleted the chore/master-to-main branchOctober 12, 2021 16:37
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JohnVillalovosJohnVillalovosJohnVillalovos approved these changes

@max-wittigmax-wittigmax-wittig approved these changes

Assignees

@JohnVillalovosJohnVillalovos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch frommaster tomain for default branch
3 participants
@nejch@JohnVillalovos@max-wittig

[8]ページ先頭

©2009-2025 Movatter.jp