NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

chore: fix type-check issue shown by new requests-types#1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/mypy_dep

Oct 6, 2021

Merged

chore: fix type-check issue shown by new requests-types#1621

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/mypy_dep

Oct 6, 2021

Conversation

Copy link

Member

JohnVillalovos commentedOct 6, 2021

types-requests==2.25.9 changed a type-hint. Update code to handle this
change.

chore: fix type-check issue shown by new requests-types

0ee9aa4

types-requests==2.25.9 changed a type-hint. Update code to handle thischange.

JohnVillalovos mentioned this pull request

Oct 6, 2021

chore(deps): update dependency types-requests to v2.25.9#1618

Merged

1 task

Copy link

codecov-commenter commentedOct 6, 2021•
edited
Loading

Codecov Report

Merging#1621 (0ee9aa4) intomaster (d97f79d) willincrease coverage by87.78%.
The diff coverage isn/a.

@@             Coverage Diff             @@##           master    #1621       +/-   ##===========================================+ Coverage        0   87.78%   +87.78%===========================================  Files           0       74       +74       Lines           0     4307     +4307     ===========================================+ Hits            0     3781     +3781- Misses          0      526      +526

Flag	Coverage Δ
cli_func_v4	`81.70% <ø> (?)`
unit	`83.51% <ø> (?)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
gitlab/client.py	`86.98% <ø> (ø)`
gitlab/base.py	`89.09% <0.00%> (ø)`
gitlab/v4/objects/custom_attributes.py	`100.00% <0.00%> (ø)`
gitlab/v4/objects/snippets.py	`83.72% <0.00%> (ø)`
gitlab/v4/objects/project_access_tokens.py	`100.00% <0.00%> (ø)`
gitlab/v4/objects/clusters.py	`85.71% <0.00%> (ø)`
gitlab/v4/objects/deploy_keys.py	`91.30% <0.00%> (ø)`
gitlab/v4/objects/boards.py	`100.00% <0.00%> (ø)`
gitlab/v4/cli.py	`81.20% <0.00%> (ø)`
gitlab/v4/objects/badges.py	`100.00% <0.00%> (ø)`
... and65 more