Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(api): add project label promotion#1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intopython-gitlab:mainfromStingRayZA:add-label-promote
Oct 20, 2021

Conversation

@StingRayZA
Copy link
Contributor

Adds a mixin that allows the/promote endpoint to be called on project labels.

Fixes#1602

@codecov-commenter
Copy link

codecov-commenter commentedSep 27, 2021•
edited
Loading

Codecov Report

Merging#1610 (c26b619) intomaster (a5d8b7f) willincrease coverage by0.03%.
The diff coverage is95.65%.

@@            Coverage Diff             @@##           master    #1610      +/-   ##==========================================+ Coverage   91.57%   91.61%   +0.03%==========================================  Files          74       74                Lines        4263     4294      +31     ==========================================+ Hits         3904     3934      +30- Misses        359      360       +1
FlagCoverage Δ
cli_func_v481.50% <65.21%> (-0.06%)⬇️
py_func_v480.71% <95.65%> (+0.14%)⬆️
unit83.27% <65.21%> (-0.07%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/mixins.py91.31% <95.00%> (+0.19%)⬆️
gitlab/exceptions.py99.29% <100.00%> (+0.01%)⬆️
gitlab/v4/objects/labels.py93.47% <100.00%> (ø)
gitlab/v4/objects/personal_access_tokens.py100.00% <0.00%> (ø)
gitlab/v4/objects/users.py98.40% <0.00%> (+0.01%)⬆️

@JohnVillalovos
Copy link
Member

Thanks for this. This is going to need some docs updates too, so that people know it is there and also how to use it.

@StingRayZA
Copy link
ContributorAuthor

Sure - will add them now the CI has given thecode a 👍

@StingRayZA
Copy link
ContributorAuthor

I've removed the CLI action (It wasn't testing well, and I don't think I know how to make it work without breaking backwards compatibility)

Also added a note into the docs...

Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you@StingRayZA! I just had a few questions.

I'm unsure if/promote is an endpoint that will appear elsewhere and warrant its own Mixin, but it looks clean this way :)

@StingRayZA
Copy link
ContributorAuthor

Thanks for the review@nejch - I've got a tweak or two to make and I'll post them ASAP...

@nejchnejch assignedStingRayZA and unassignednejchOct 17, 2021
@nejch
Copy link
Member

Thanks again@StingRayZA. Just a nitpick for tests and if you could maybe rebase on top ofmain? :)

Adds a mixin that allows the /promote endpoint to be called.Signed-off-by: Raimund Hook <raimund.hook@exfo.com>
@StingRayZA
Copy link
ContributorAuthor

All done@nejch - updated and rebased 😁

@nejchnejch merged commit853d850 intopython-gitlab:mainOct 20, 2021
@nejch
Copy link
Member

Thanks for the contribution@StingRayZA! :) Looking forward to the milestone PR 😁

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nejchnejchAwaiting requested review from nejch

Assignees

@StingRayZAStingRayZA

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature Request: Support promoting project labels

4 participants

@StingRayZA@codecov-commenter@JohnVillalovos@nejch
[8]ページ先頭
©2009-2025 Movatter.jp