- Notifications
You must be signed in to change notification settings - Fork673
fix: urlencode id part of path#1606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-commenter commentedSep 29, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #1606 +/- ##==========================================+ Coverage 91.59% 91.85% +0.25%========================================== Files 74 74 Lines 4272 4295 +23 ==========================================+ Hits 3913 3945 +32+ Misses 359 350 -9
Flags with carried forward coverage won't be shown.Click here to find out more.
|
@nejch this PR should be ready for review/merge |
Hi@Pro, thanks for this PR. Just a few notes on this:
|
I squashed all the commits. Currently I cannot invest more time into writing tests, maybe in a few weeks when there is more time, sorry. |
@Pro this might need a rebase now as we've switched to f-strings. |
Hi@Pro! This was part of a much larger URL-encoding issue and this PR provides a specific solution in I believe we have now solved the underlying issue in a more general way that solves it for all endpoints and ensures a string is only ever URL-encoded once:#1819. So I'll close this PR as I think the issue is fixed and we have tests for this now. But thanks again for your contribution, it showed us how widespread the URL-encoding problem was. Feel free to report any more issues or PRs if you find anything else :) |
The
tag_name
part of the path must be urlencoded.Found this issue when trying to update a release which has a slash in its title, e.g., "1.2.3/testing"
See also:
https://docs.gitlab.com/ee/api/releases/index.html#update-a-release