Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: urlencode id part of path#1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Pro wants to merge1 commit intopython-gitlab:mainfromPro:feat-urlencode

Conversation

Pro
Copy link

@ProPro commentedSep 22, 2021

Thetag_name part of the path must be urlencoded.

Found this issue when trying to update a release which has a slash in its title, e.g., "1.2.3/testing"

See also:
https://docs.gitlab.com/ee/api/releases/index.html#update-a-release

@codecov-commenter
Copy link

codecov-commenter commentedSep 29, 2021
edited
Loading

Codecov Report

Merging#1606 (6944bc7) intomaster (227607c) willincrease coverage by0.25%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##           master    #1606      +/-   ##==========================================+ Coverage   91.59%   91.85%   +0.25%==========================================  Files          74       74                Lines        4272     4295      +23     ==========================================+ Hits         3913     3945      +32+ Misses        359      350       -9
FlagCoverage Δ
cli_func_v481.86% <100.00%> (+0.26%)⬆️
py_func_v480.88% <100.00%> (+0.26%)⬆️
unit83.67% <100.00%> (+0.29%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/mixins.py91.14% <100.00%> (+0.02%)⬆️
gitlab/v4/objects/container_registry.py83.33% <0.00%> (ø)
gitlab/v4/objects/users.py98.43% <0.00%> (+0.03%)⬆️
gitlab/v4/objects/merge_request_approvals.py93.05% <0.00%> (+0.19%)⬆️
gitlab/client.py89.79% <0.00%> (+0.93%)⬆️
gitlab/v4/objects/branches.py100.00% <0.00%> (+26.47%)⬆️

@Pro
Copy link
Author

Pro commentedOct 8, 2021

@nejch this PR should be ready for review/merge

@nejch
Copy link
Member

Hi@Pro, thanks for this PR. Just a few notes on this:

@Pro
Copy link
Author

Pro commentedOct 8, 2021

I squashed all the commits. Currently I cannot invest more time into writing tests, maybe in a few weeks when there is more time, sorry.

@nejch
Copy link
Member

@Pro this might need a rebase now as we've switched to f-strings.

@nejch
Copy link
Member

Hi@Pro! This was part of a much larger URL-encoding issue and this PR provides a specific solution inupdate().

I believe we have now solved the underlying issue in a more general way that solves it for all endpoints and ensures a string is only ever URL-encoded once:#1819.

So I'll close this PR as I think the issue is fixed and we have tests for this now. But thanks again for your contribution, it showed us how widespread the URL-encoding problem was. Feel free to report any more issues or PRs if you find anything else :)

Pro reacted with heart emoji

@nejchnejch closed thisJan 13, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@ProPro

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Pro@codecov-commenter@nejch

[8]ページ先頭

©2009-2025 Movatter.jp