Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(objects): rename confusingto_project_id argument#1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JohnVillalovos merged 1 commit intomasterfromfix/group-transfer-project-arg
Sep 11, 2021

Conversation

nejch
Copy link
Member

BREAKING CHANGE: rename confusingto_project_id argument in transfer_project
toproject_id (--project-id in CLI). This is used for the source project,
not for the target namespace.

Closes#1529.

chris-peterson reacted with thumbs up emoji
BREAKING CHANGE: rename confusing `to_project_id` argument in transfer_projectto `project_id` (`--project-id` in CLI). This is used for the source project,not for the target namespace.
@codecov-commenter
Copy link

codecov-commenter commentedSep 11, 2021•
edited by codecovbot
Loading

Codecov Report

Attention: Patch coverage is66.66667% with1 line in your changes missing coverage. Please review.

Project coverage is 91.57%. Comparing base(3f320af) to head(ab1420c).

Files with missing linesPatch %Lines
gitlab/v4/objects/groups.py66.66%1 Missing⚠️
Additional details and impacted files
@@           Coverage Diff           @@##           master    #1599   +/-   ##=======================================  Coverage   91.57%   91.57%           =======================================  Files          74       74             Lines        4263     4263           =======================================  Hits         3904     3904             Misses        359      359
FlagCoverage Δ
cli_func_v481.56% <66.66%> (ø)
py_func_v480.57% <66.66%> (ø)
unit83.34% <66.66%> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
gitlab/v4/objects/groups.py87.20% <66.66%> (ø)

@JohnVillalovosJohnVillalovos merged commitce4bc0d intomasterSep 11, 2021
@JohnVillalovosJohnVillalovos deleted the fix/group-transfer-project-arg branchSeptember 11, 2021 16:17
@nejchnejch mentioned this pull requestJan 5, 2022
15 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JohnVillalovosJohnVillalovosJohnVillalovos approved these changes

Assignees

@JohnVillalovosJohnVillalovos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

group transfer-project is confusing
3 participants
@nejch@codecov-commenter@JohnVillalovos
[8]ページ先頭
©2009-2025 Movatter.jp