- Notifications
You must be signed in to change notification settings - Fork673
refactor(objects): remove deprecated branch protect methods#1598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
BREAKING CHANGE: remove deprecated branch protect methods in favor ofthe more complete protected branches API.
JohnVillalovos approved these changesSep 11, 2021
JohnVillalovos approved these changesOct 6, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: remove deprecated branch protect methods in favor of
the more complete Protected branches API.
Closes#821.
@max-wittig WDYT about removing this completely? Then people will stop getting confused about the two APIs like in#1355 and#821. The endpoint still technically works, but the GitLab API docs removed it ages ago and they point to the dedicated protected branches API now (https://docs.gitlab.com/ee/api/branches.html#protect-repository-branch).
Last time we kept a deprecated endpoint (release via tags API) it bit us because GitLab then "silently" removed it. Just adding this to the list of breaking changes as the next scheduled job will trigger 3.0.0.