- Notifications
You must be signed in to change notification settings - Fork673
refactor(objects): remove deprecated constants defined in objects#1593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecov-commenter commentedSep 8, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #1593 +/- ##==========================================- Coverage 91.59% 91.57% -0.02%========================================== Files 74 74 Lines 4272 4263 -9 ==========================================- Hits 3913 3904 -9 Misses 359 359
Flags with carried forward coverage won't be shown.Click here to find out more.
|
BREAKING CHANGE: remove deprecated constants defined ingitlab.v4.objects, and use only gitlab.const module
ce39754 tob8d379dCompareJohnVillalovos approved these changesSep 11, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
BREAKING CHANGE: remove deprecated constants defined in gitlab.v4.objects, and use only gitlab.const module
FYI: the visibility as int constants can safely be changed to string - they were only used in GitLab API v3 prior to gitlab v9.0.https://gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/9337