Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added merge_base API endpoint support#1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

GerevSec
Copy link

@GerevSecGerevSec commentedAug 26, 2021
edited by nejch
Loading

Added simple merge_base API endpoint support, based on the repository_compare code.

Closes#1495.

zoidyzoidzoid reacted with heart emoji
@codecov-commenter
Copy link

codecov-commenter commentedSep 12, 2021
edited by codecovbot
Loading

Codecov Report

Attention: Patch coverage is60.00000% with2 lines in your changes missing coverage. Please review.

Project coverage is 91.12%. Comparing base(e54832a) to head(1730fcb).
Report is 1411 commits behind head on main.

Files with missing linesPatch %Lines
gitlab/v4/objects/repositories.py60.00%2 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #1577      +/-   ##==========================================- Coverage   91.16%   91.12%   -0.04%==========================================  Files          74       74                Lines        4177     4182       +5     ==========================================+ Hits         3808     3811       +3- Misses        369      371       +2
FlagCoverage Δ
cli_func_v480.72% <60.00%> (-0.03%)⬇️
py_func_v480.08% <60.00%> (-0.03%)⬇️
unit82.28% <60.00%> (-0.03%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
gitlab/v4/objects/repositories.py79.68% <60.00%> (-1.67%)⬇️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nejch
Copy link
Member

Hi@GerevSec, thanks a lot for your contribution! We just need a few things to get this green:

  1. git commit --amend your commit message to follow conventional commit, e.g.feat(objects): add merge_base API support
  2. run black to format code properly, e.g. withtox -e black
  3. If possible, could you add some documentation and unit tests? for inspiration, see:

@github-actions
Copy link

This Pull Request (PR) was marked stale because it has been open 90 days with no activity. Please remove the stale label or comment on this PR. Otherwise, it will be closed in 15 days.

@github-actions
Copy link

This PR was closed because it has been marked stale for 15 days with no activity. If this PR is still valid, please re-open.

@emadimehrdad
Copy link

@nejch@GerevSec
Hi.
Do you have any plan to develop this feature?

@emadimehrdad
Copy link

Hi@nejch
Would you want me to continue this Pull Request? I think this feature will be useful.

@nejch
Copy link
Member

Thanks for the ping again@emadimehrdad, this one slipped a little bit. Yes, we'll pick it up and add some tests to get this merged :)

emadimehrdad reacted with thumbs up emoji

@nejchnejch assignednejch and unassignedGerevSecJun 15, 2022
@nejch
Copy link
Member

As it is, I don't think we can merge a PR with this change alone - the API expects 2or more refs (arbitrary number), which need to be supplied as an array. So we'll also need#1699 first.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@nejchnejch

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No merge_base API support while GitLab v4 API has.
4 participants
@GerevSec@codecov-commenter@nejch@emadimehrdad

[8]ページ先頭

©2009-2025 Movatter.jp