Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: fix mypy pre-commit hook#1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JohnVillalovos merged 3 commits intomasterfromchore/fix-mypy-pre-commit
Aug 23, 2021

Conversation

nejch
Copy link
Member

@nejchnejch commentedAug 1, 2021•
edited
Loading

Closes#1539.

Additionally, since mypy 0.910 doesn't bundle stubs anymore we need to track them for pre-commit's own virtualenv :/ Seepre-commit/pre-commit#730

@nejchnejch marked this pull request as draftAugust 1, 2021 12:29
@nejchnejchforce-pushed thechore/fix-mypy-pre-commit branch from7db1482 to430c332CompareAugust 1, 2021 12:31
@nejchnejch mentioned this pull requestAug 1, 2021
@nejchnejch marked this pull request as ready for reviewAugust 1, 2021 19:00
@javatarz
Copy link
Contributor

Can we please get this merged? The pre-commit hooks are broken and themypy stage blocks commits every time.

The workaround I've been using is to disablemypy locally (via a commit) and then remove the commit before pushing. This is painful.

@nejch
Copy link
MemberAuthor

Can we please get this merged? The pre-commit hooks are broken and themypy stage blocks commits every time.

The workaround I've been using is to disablemypy locally (via a commit) and then remove the commit before pushing. This is painful.

Sorry, I know this was really annoying!

@JohnVillalovos I'm back from the dead 😆 would you be able to take a quick look/merge?

javatarz reacted with thumbs up emoji

@JohnVillalovosJohnVillalovos merged commit7a64e67 intomasterAug 23, 2021
@JohnVillalovosJohnVillalovos deleted the chore/fix-mypy-pre-commit branchAugust 23, 2021 05:25
@JohnVillalovos
Copy link
Member

Thanks@nejch !

javatarz reacted with hooray emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JohnVillalovosJohnVillalovosAwaiting requested review from JohnVillalovos

2 more reviewers

@antti-mikaelantti-mikaelantti-mikael left review comments

@javatarzjavatarzjavatarz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pre-commit hook for mypy fails

4 participants

@nejch@javatarz@JohnVillalovos@antti-mikael
[8]ページ先頭
©2009-2025 Movatter.jp