Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add only_allow_merge_if_build_succeeds option to project objects#155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gpocentek merged 2 commits intopython-gitlab:masterfromrafaeleyng:add-only_allow_merge_if_build_succeeds
Sep 23, 2016
Merged

add only_allow_merge_if_build_succeeds option to project objects#155

gpocentek merged 2 commits intopython-gitlab:masterfromrafaeleyng:add-only_allow_merge_if_build_succeeds
Sep 23, 2016

Conversation

rafaeleyng
Copy link
Contributor

No description provided.

marcoblos reacted with hooray emoji
@gpocentek
Copy link
Contributor

The patch looks good, thank you. Please fix the pep8 failure and I'll merge.

@gpocentekgpocentek merged commit26d97a7 intopython-gitlab:masterSep 23, 2016
@rafaeleyngrafaeleyng deleted the add-only_allow_merge_if_build_succeeds branchSeptember 23, 2016 17:08
@rafaeleyng
Copy link
ContributorAuthor

It didn't work =(

I tried:

    project.only_allow_merge_if_build_succeeds = True    project.save()

and

    project.only_allow_merge_if_build_succeeds = 1    project.save()

but none worked.

Am I doing something wrong?

@gpocentek
Copy link
Contributor

I tested here and everything seems to work, using a boolean value. Are you sure that your gitlab version support this attribute? It's recent.

@rafaeleyng
Copy link
ContributorAuthor

rafaeleyng commentedSep 29, 2016
edited
Loading

I can set this value using the GUI, but I'm not sure about the API support.

Since I'm no Python developer, I may have done something wrong. Here is what I did:

$ sudo pip uninstall python-gitlab$ git clone https://github.com/gpocentek/python-gitlab.git$ cd python-gitlab$ python setup.py install

Does this suffice to use the newest version containing the change introduced in this MR?

@gpocentek
Copy link
Contributor

Yes you should be able to use your change. Do you know the version of the gitlab server?

@gpocentek
Copy link
Contributor

From what I see in the git log you need gitlab 8.12 to get this feature in the API.

@rafaeleyng
Copy link
ContributorAuthor

We are using GitLab Community Edition 8.9.0.

I'll try to update and give you some input again.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@rafaeleyng@gpocentek

[8]ページ先頭

©2009-2025 Movatter.jp