Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(api): replace deprecatedname_regex attribute indelete_in_bulk()#1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

antti-mikael
Copy link
Contributor

Thename_regex attribute has been deprecated in favor ofname_regex_delete.
See:https://gitlab.com/gitlab-org/gitlab/-/commit/ce99813cf54

frwickst reacted with thumbs up emoji
@codecov-commenter
Copy link

codecov-commenter commentedJun 29, 2021•
edited
Loading

Codecov Report

Merging#1536 (6c419ee) intomaster (b8a47ba) willincrease coverage by0.40%.
The diff coverage is50.00%.

@@            Coverage Diff             @@##           master    #1536      +/-   ##==========================================+ Coverage   91.18%   91.59%   +0.40%==========================================  Files          74       74                Lines        4188     4272      +84     ==========================================+ Hits         3819     3913      +94+ Misses        369      359      -10
FlagCoverage Δ
cli_func_v481.60% <50.00%> (+0.79%)⬆️
py_func_v480.61% <50.00%> (+0.46%)⬆️
unit83.38% <50.00%> (+0.88%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/v4/objects/container_registry.py83.33% <50.00%> (ø)
gitlab/mixins.py91.12% <0.00%> (-0.36%)⬇️
gitlab/v4/cli.py81.20% <0.00%> (-0.31%)⬇️
gitlab/v4/objects/pipelines.py94.44% <0.00%> (-0.18%)⬇️
gitlab/const.py100.00% <0.00%> (ø)
gitlab/v4/objects/members.py100.00% <0.00%> (ø)
gitlab/v4/objects/releases.py100.00% <0.00%> (ø)
gitlab/v4/objects/snippets.py97.67% <0.00%> (+0.11%)⬆️
gitlab/v4/objects/users.py98.38% <0.00%> (+0.13%)⬆️
gitlab/v4/objects/commits.py94.36% <0.00%> (+0.16%)⬆️
... and8 more

Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot@antti-mikael! Just a small note on keeping the arguments in sync with the API.

@antti-mikaelantti-mikaelforce-pushed thefix/registry-deleteinbulk-deprecated-attr branch from8b5d647 todb6eed0CompareJuly 1, 2021 07:38
@antti-mikaelantti-mikael requested a review fromnejchJuly 5, 2021 06:46
@antti-mikaelantti-mikaelforce-pushed thefix/registry-deleteinbulk-deprecated-attr branch 2 times, most recently from1dcc077 to6c419eeCompareSeptember 9, 2021 10:00
The `name_regex` attribute has been deprecated in favor of`name_regex_delete`.See:https://gitlab.com/gitlab-org/gitlab/-/commit/ce99813cf54
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JohnVillalovosJohnVillalovosJohnVillalovos left review comments

@nejchnejchAwaiting requested review from nejch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@antti-mikael@codecov-commenter@JohnVillalovos@nejch
[8]ページ先頭
©2009-2025 Movatter.jp