Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Support Release edition API#1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 5 commits intopython-gitlab:masterfromPPaques:1521-releases-edit
Jun 26, 2021

Conversation

PPaques
Copy link
Contributor

@PPaquesPPaques commentedJun 15, 2021•
edited
Loading

Following#1521:

  • Removal of the documentation for deprecated API
  • Support the PUT function of therelease API
  • Add documentation
  • unit-test + integration test (well, I've tried)

Closes#1521

@codecov-commenter
Copy link

codecov-commenter commentedJun 15, 2021•
edited
Loading

Codecov Report

Merging#1522 (13bf61d) intomaster (2c86003) willincrease coverage by0.00%.
The diff coverage is100.00%.

@@           Coverage Diff           @@##           master    #1522   +/-   ##=======================================  Coverage   91.13%   91.13%           =======================================  Files          74       74             Lines        4162     4163    +1     =======================================+ Hits         3793     3794    +1  Misses        369      369
FlagCoverage Δ
cli_func_v480.73% <100.00%> (+<0.01%)⬆️
py_func_v480.03% <100.00%> (+<0.01%)⬆️
unit82.29% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/v4/objects/releases.py100.00% <100.00%> (ø)

@nejch
Copy link
Member

Thanks a lot@PPaques, could you please runtox -e black to format the code, and change your commit messages to usetest type instead oftests :) a quickgit rebase -i <base SHA> should do!

@PPaques
Copy link
ContributorAuthor

Done :)

I had to do agit commit -n for unit-test and integration parts.

The pre-commit hookmypymypy was complaining a lot abouttests/functional/api/test_releases.py:*: error: Function is missing a type annotation

@PPaquesPPaquesforce-pushed the1521-releases-edit branch 2 times, most recently fromdd5b5c6 tod465eaaCompareJune 16, 2021 08:03
@PPaques
Copy link
ContributorAuthor

The push was just for commit emails and GPG.
I used my work address and GPG which was not linked to GitHub (make it complaining that it wasn't possible to link commits with my account)

Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks again@PPaques! Just a small note on the functional tests, if you could take a look. Sorry for the delay.

@PPaquesPPaques marked this pull request as draftJune 26, 2021 07:31
@PPaquesPPaques marked this pull request as ready for reviewJune 26, 2021 19:16
@nejchnejch merged commit33d3428 intopython-gitlab:masterJun 26, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nejchnejchnejch approved these changes

Assignees

@PPaquesPPaques

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate tag.set_release_description and remove it from docs
3 participants
@PPaques@codecov-commenter@nejch
[8]ページ先頭
©2009-2025 Movatter.jp