- Notifications
You must be signed in to change notification settings - Fork673
feat: add keys endpoint#1490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
On a somewhat unrelated note, is there a reason flake8 isn't included in the pre-commit config? |
codecov-commenter commentedJun 2, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #1490 +/- ##==========================================+ Coverage 91.01% 91.04% +0.03%========================================== Files 73 74 +1 Lines 4128 4145 +17 ==========================================+ Hits 3757 3774 +17 Misses 371 371
Flags with carried forward coverage won't be shown.Click here to find out more.
|
JohnVillalovos commentedJun 2, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Good catch.@nejch recently updated it to add |
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Thanks!
I'd like@nejch and/or@max-wittig to also look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks a lot, looks great! Just 2 tiny comments :)
gitlab/v4/objects/keys.py Outdated
| return super(KeyManager, self).get(id, **kwargs) | ||
| if "fingerprint" not in kwargs: | ||
| raise AttributeError("Missing attribute: fingerprint") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should probably have both options:
| raiseAttributeError("Missing attribute: fingerprint") | |
| raiseAttributeError("Missing attribute:id orfingerprint") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done.
Uh oh!
There was an error while loading.Please reload this page.
Yes, these were just very recent additions to CI checks but we should add pre-commit as well. |
While this endpoint may be a little niche, it was useful for a project I was involved in recently.