Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add type-hints to gitlab/v4/cli.py#1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/mypy_cli
Jun 1, 2021
Merged

chore: add type-hints to gitlab/v4/cli.py#1483

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/mypy_cli
Jun 1, 2021

Conversation

JohnVillalovos
Copy link
Member

  • Add type-hints to gitlab/v4/cli.py
  • Add required type-hints to other files based on adding type-hints
    to gitlab/v4/cli.py

@codecov-commenter
Copy link

codecov-commenter commentedMay 30, 2021•
edited
Loading

Codecov Report

Merging#1483 (2673af0) intomaster (fbbc0d4) willdecrease coverage by0.02%.
The diff coverage is95.74%.

@@            Coverage Diff             @@##           master    #1483      +/-   ##==========================================- Coverage   90.98%   90.95%   -0.03%==========================================  Files          73       73                Lines        4080     4090      +10     ==========================================+ Hits         3712     3720       +8- Misses        368      370       +2
FlagCoverage Δ
cli_func_v480.61% <95.74%> (-0.01%)⬇️
py_func_v479.77% <0.00%> (-0.20%)⬇️
unit81.98% <46.80%> (-0.16%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
gitlab/v4/cli.py81.13% <95.74%> (-0.05%)⬇️

  * Add type-hints to gitlab/v4/cli.py  * Add required type-hints to other files based on adding type-hints    to gitlab/v4/cli.py
Copy link
Member

@nejchnejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! Just one question :)

@nejchnejch merged commit55ae61a intopython-gitlab:masterJun 1, 2021
@JohnVillalovosJohnVillalovos deleted the jlvillal/mypy_cli branchJanuary 4, 2022 06:59
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nejchnejchnejch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@JohnVillalovos@codecov-commenter@nejch
[8]ページ先頭
©2009-2025 Movatter.jp