NotificationsYou must be signed in to change notification settings
Fork673
Star2.4k

chore: make certain dotfiles searchable by ripgrep#1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/gitignore

May 29, 2021

Merged

chore: make certain dotfiles searchable by ripgrep#1475

nejch merged 1 commit intopython-gitlab:masterfromJohnVillalovos:jlvillal/gitignore

May 29, 2021

Conversation

Copy link

Member

JohnVillalovos commentedMay 27, 2021

By explicitly NOT excluding the dotfiles we care about to the
.gitignore file we make those files searchable by tools like ripgrep.

By default dotfiles are ignored by ripgrep and other search tools (not
grep)

JohnVillalovos requested review frommax-wittig andnejch

May 27, 2021 04:09

nejch requested changes

May 29, 2021

View reviewed changes

Copy link

Member

nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! I have a feeling we might forget to maintain this list, but it can't hurt 😀 Maybe this can be improved by reducing dotfile clutter also, a few more tools now supportpyproject.toml and some stuff can go in.github/, I'll push a follow-up PR.

Just saw we're missing a few entries though.

.gitignoreShow resolvedHide resolved

.gitignore OutdatedShow resolvedHide resolved

chore: make certain dotfiles searchable by ripgrep

e4ce078

By explicitly NOT excluding the dotfiles we care about to the.gitignore file we make those files searchable by tools like ripgrep.By default dotfiles are ignored by ripgrep and other search tools (notgrep)

Copy link

codecov-commenter commentedMay 29, 2021•
edited
Loading

Codecov Report

Merging#1475 (e4ce078) intomaster (90ecf2f) willdecrease coverage by4.53%.
The diff coverage isn/a.

@@            Coverage Diff             @@##           master    #1475      +/-   ##==========================================- Coverage   90.91%   86.37%   -4.54%==========================================  Files          73       73                Lines        4051     4052       +1     ==========================================- Hits         3683     3500     -183- Misses        368      552     +184

Flag	Coverage Δ
cli_func_v4	`80.47% <ø> (+<0.01%)`	⬆️
py_func_v4	`?`
unit	`82.00% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
gitlab/v4/objects/files.py	`61.76% <0.00%> (-30.89%)`	⬇️
gitlab/v4/objects/milestones.py	`71.42% <0.00%> (-28.58%)`	⬇️
gitlab/v4/objects/tags.py	`63.88% <0.00%> (-25.00%)`	⬇️
gitlab/utils.py	`65.51% <0.00%> (-24.14%)`	⬇️
gitlab/v4/objects/repositories.py	`57.62% <0.00%> (-23.73%)`	⬇️
gitlab/v4/objects/sidekiq.py	`80.95% <0.00%> (-19.05%)`	⬇️
gitlab/v4/objects/commits.py	`78.26% <0.00%> (-15.95%)`	⬇️
gitlab/v4/objects/snippets.py	`82.92% <0.00%> (-14.64%)`	⬇️
gitlab/v4/objects/clusters.py	`85.71% <0.00%> (-14.29%)`	⬇️
gitlab/v4/objects/environments.py	`88.23% <0.00%> (-11.77%)`	⬇️
... and12 more